Skip to content

chore: updating sharp to 32.05 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

achepukov
Copy link
Contributor

Can we update dependencies once again?

@jwagner
Copy link
Owner

jwagner commented Aug 18, 2023

Yes. Wondering whether it's worth to just set the peer dependency version to *. It's wrong based on semver, in the sense that changes to sharp could break smartcrop-sharp but in practice I feel like the current process is worse. There weren't any issues for something like 20 releases of sharp so far but a lot of grief because the library wasn't updated. I guess the alternative would be to automated the updating, which would at least run the tests but that's more work.

What do you think would be a good solution for the future @achepukov ? :)

@jwagner jwagner merged commit 94bda87 into jwagner:main Aug 18, 2023
@achepukov
Copy link
Contributor Author

achepukov commented Aug 21, 2023

@jwagner thanks for quick merge, you Rock!

Imo it's acceptable to use *, and point to the README.md that latest tested version was x.y.z or something. I guess you'll got an issue if any, and perhaps with PR.

In terms of the best solution - I agree that it should be auto tests + version bump for every sharp release. Can I help you with that?

@achepukov
Copy link
Contributor Author

@jwagner could you please release latest main?

@achepukov
Copy link
Contributor Author

@jwagner I mean publish 2.0.8

@achepukov achepukov deleted the sharp-32.5 branch August 22, 2023 05:26
@achepukov
Copy link
Contributor Author

Yeah, looks like last 3 - 4 releases you did only update sharp dependencies )))
I'm going to create PR to bind sharp to *
Screenshot 2023-08-23 at 15 43 59

@jwagner
Copy link
Owner

jwagner commented Aug 23, 2023

I'm currently traveling, will get back to this as soon as I'm back, likely next Monday. Sorry for the delay.

@achepukov
Copy link
Contributor Author

@jwagner ok, have a great trip! )
This should resolve your pain regarding sharp updates

@achepukov
Copy link
Contributor Author

@jwagner may I hope for a release this week? :)
Again, feel free to ask for help if anything

@jwagner
Copy link
Owner

jwagner commented Sep 4, 2023

Hey @achepukov thank you for your patience! I had an accident during my vacation that I'm still recovering from. I'll try to release the dependency update today and review the PR semver change later when I have a bit more spare mental capacity.

@achepukov
Copy link
Contributor Author

Thanks a lot Man! Take care! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants