Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/issue-95-poetry-dependency-groups #136

Merged

Conversation

njlr
Copy link
Contributor

@njlr njlr commented Dec 21, 2024

Add support for Poetry dependency groups

Closes #95

@njlr
Copy link
Contributor Author

njlr commented Jan 3, 2025

@jvolkman Please can you have a look at this?

@jvolkman
Copy link
Owner

jvolkman commented Jan 6, 2025

Can you adopt the pattern that the PDM (and I guess uv) translators use? Specifically, these attrs: https://github.com/jvolkman/rules_pycross/blob/main/pycross/private/lock_attrs.bzl#L113-L124

It's not clear to me that Poetry differentiates between optional and dev dependencies. If not, maybe just add optional_groups and all_optional_groups for the Poetry translator.

@jvolkman jvolkman mentioned this pull request Jan 6, 2025
@njlr
Copy link
Contributor Author

njlr commented Jan 6, 2025

Can you adopt the pattern that the PDM (and I guess uv) translators use? Specifically, these attrs: https://github.com/jvolkman/rules_pycross/blob/main/pycross/private/lock_attrs.bzl#L113-L124

It's not clear to me that Poetry differentiates between optional and dev dependencies. If not, maybe just add optional_groups and all_optional_groups for the Poetry translator.

I had a go at this.

Is CONTRIBUTING.md up-to-date?

bazel run //:gazelle

Gives me errors


Edit: CI now passes

Copy link
Owner

@jvolkman jvolkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jvolkman jvolkman merged commit 5598e21 into jvolkman:main Jan 7, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are Poetry dependency groups supported?
2 participants