Some AppStream improvements #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch the component type from "desktop" (pre-2016) to "desktop-application" - add <launchable> tag to point to the desktop file - add <provides> tag listing the two binaries provided (the game and the editor) - add an <url> tag for the list of issues
The editor is already represented as part of the AppStream metadata of the game itself, and thus it does not need its own; hence, tell AppStream to ignore this desktop file.
|
You could also add <developer_name>Jussi Lind</developer_name>which is required now. |
According to https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html developer_name is deprecated and should be replaced with developer ? |
|
Yes, a reverse DNS developer ID would be even better, but I wasn't sure you have one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dustrac-editor.desktopfor AppStreamSee the messages of the individual commits for longer explanations.