-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pie-link): DSW-2378 to use @playwright/test
& storybook for testing
#2162
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment!
packages/components/pie-link/test/accessibility/pie-link.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment
Co-authored-by: Raouf <[email protected]>
Describe your changes (can list changeset entries if preferable)
aria
props and controls into StorybookComponent
,Accessibility
andVisual
tests from@sand4rt/experimental-ct-web
package to@playwright/test
as well as correspondingplaywright-lit
configs.Note:
There is a minor problem we have found with the labelling for the iconSlot within the variants visual test that we were not able to solve. I have since created a follow up ticket to address this post refactors.
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook
/PIE Docs
PR preview.Not-applicable Checklist items
/test-aperture
command.Reviewer checklists (complete before approving)
Mark items as
[-] N/A
if not applicable.Reviewer 1 -
PIE Storybook
/PIE Docs
PR preview.Reviewer 2 -
PIE Storybook
/PIE Docs
PR preview.