Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pie-link): DSW-2378 to use @playwright/test & storybook for testing #2162

Merged
merged 12 commits into from
Jan 17, 2025

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Jan 16, 2025

Describe your changes (can list changeset entries if preferable)

  • Added Link test story to Storybook testing folder
  • Added turbo.json to stop component building locally
  • Added missing aria props and controls into Storybook
  • Updated Component, Accessibility and Visual tests from @sand4rt/experimental-ct-web package to @playwright/test as well as corresponding playwright-lit configs.

Note:
There is a minor problem we have found with the labelling for the iconSlot within the variants visual test that we were not able to solve. I have since created a follow up ticket to address this post refactors.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.

Not-applicable Checklist items

  • [-] - NA I have added thorough tests where applicable (unit / component / visual).
  • [-] - NA If changes will affect consumers of the package, I have created a changeset entry.
  • [-] - NA If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 -

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A - I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2 -

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A - I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners January 16, 2025 15:44
Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: c240663

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@siggerzz siggerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment!

siggerzz
siggerzz previously approved these changes Jan 17, 2025
raoufswe
raoufswe previously approved these changes Jan 17, 2025
Copy link
Member

@raoufswe raoufswe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment

@JoshuaNg2332 JoshuaNg2332 dismissed stale reviews from raoufswe and siggerzz via 1fdcbd7 January 17, 2025 14:20
siggerzz
siggerzz previously approved these changes Jan 17, 2025
@JoshuaNg2332 JoshuaNg2332 merged commit 3c492a7 into main Jan 17, 2025
35 of 37 checks passed
@JoshuaNg2332 JoshuaNg2332 deleted the DSW-2378-pie-link-migration-refactor branch January 17, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants