Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-cookie-banner): DSW-000 fix cookie-banner tests #2154

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

siggerzz
Copy link
Contributor

@siggerzz siggerzz commented Jan 13, 2025

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • [-] N/A I have reviewed visual test updates properly before approving.
  • [-] N/A I have added thorough tests where applicable (unit / component / visual).
  • [-] N/A If changes will affect consumers of the package, I have created a changeset entry.
  • [-] N/A If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @JoshuaNg2332

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] N/A I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • [-] N/A If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] N/A I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • [-] N/A If there are visual test updates, I have reviewed them.

@siggerzz siggerzz requested review from a team as code owners January 13, 2025 15:16
Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 71062a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siggerzz siggerzz changed the title fix(pie-cookie-banner): fix cookie-banner tests fix(pie-cookie-banner): DSW-000 fix cookie-banner tests Jan 13, 2025
@siggerzz siggerzz merged commit 8880843 into main Jan 13, 2025
33 of 38 checks passed
@siggerzz siggerzz deleted the dsw-000-modal-fix-page-object branch January 13, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants