Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-toast-provider): DSW-0000 move toast and toast provider to beta #2144

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Jan 9, 2025

Describe your changes (can list changeset entries if preferable)

  • Moved the toast and toast-provider component to beta

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • [-] N/A I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] N/A I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • [-] N/A If there are visual test updates, I have reviewed them.

Reviewer 2

  • [-] N/A I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] N/A I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • [-] N/A If there are visual test updates, I have reviewed them.

@raoufswe raoufswe requested review from a team as code owners January 9, 2025 14:38
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 4ee1c6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@justeattakeaway/pie-toast-provider Minor
@justeattakeaway/pie-toast Minor
pie-docs Minor
pie-storybook Minor
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe raoufswe merged commit 6820b64 into main Jan 9, 2025
34 of 37 checks passed
@raoufswe raoufswe deleted the dsw-0000-toast-beta branch January 9, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants