Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-text-input): DSW-000 component font fixes #2115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashleynolan
Copy link
Contributor

@ashleynolan ashleynolan commented Dec 9, 2024

Describe your changes (can list changeset entries if preferable)

  • [Fixed] - font-size for text-input now contains px unit
  • [Fixed] - divider font-size set to 16px (no visual change to storybook, but will correct consuming applications using the component)

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Not-applicable Checklist items

  • I have added thorough tests where applicable (unit / component / visual).
  • If changes will affect consumers of the package, I have created a changeset entry.

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@ashleynolan ashleynolan requested review from a team as code owners December 9, 2024 12:10
Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: abe4afa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@justeattakeaway/pie-text-input Minor
@justeattakeaway/pie-divider Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-cookie-banner Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Dec 9, 2024




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against abe4afa

@github-actions github-actions bot temporarily deployed to storybook-pr-2115 December 9, 2024 12:16 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2115 December 9, 2024 12:16 Inactive
@ashleynolan ashleynolan changed the title fix(pie-divider): DSW-000 divider font-size set to 16px fix(pie-divider): DSW-000 component font fixes Dec 9, 2024
@ashleynolan ashleynolan changed the title fix(pie-divider): DSW-000 component font fixes fix(pie-text-input): DSW-000 component font fixes Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants