Fix the alreadyHighlighted issue #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
So nice @cyrilf, perfect pull request and documentation... |
This was referenced Feb 2, 2024
arnonrdp
approved these changes
Feb 4, 2024
|
@justcaliturner, please merge it. |
|
@justcaliturner – please merge this |
|
Poking again to hopefully get this merged; We're going on 6 months now. I'm currently able to get by installing |
|
@justcaliturner please merge :D |
|
@TheRockettek @nickfrosty |
|
@justcaliturner – please merge this |
|
? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug
Since the
v11.9.0of highlight.js there is no highlighting on my code.The console show me this message:
Element previously highlighted. To highlight again, first unset 'dataset.highlighted'.I've seen that even though it's a minor update, some breaking changes were introduced (as you can read on the release note).
You can see the commit responsible for the issue here.
The first comment on this commit actually explains how to fix this breaking change.
This is what I did on your code.
(please note, that I've not tested this fix).
#️⃣ Versions:
I'm using "simple-code-editor": "2.0.9" (which use "highlight.js": "11.9.0").
🏅 Bonus
This will also close: