Added check for keys

jupyterlab · Oct 19, 2023 · d520616 · d520616
1 parent 36fcbad
commit d520616
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/commands/src/index.ts b/packages/commands/src/index.ts
@@ -1167,7 +1167,7 @@ export namespace CommandRegistry {
     if (parts.cmd && Platform.IS_MAC) {
       mods += 'Cmd ';
     }
-    if (parts.key.trim() === '') {
+    if (!parts.key) {
       return mods.trim();
     }
     return mods + parts.key;
@@ -1267,7 +1267,7 @@ export namespace CommandRegistry {
     if (event.metaKey && Platform.IS_MAC) {
       mods.push('Cmd');
     }
-    if (!mods.includes(event.key) && !event.ctrlKey) {
+    if (!layout.isModifierKey(key)) {
       mods.push(key);
     }