Add submodules display #1374
Merged
Add submodules display #1374
+391
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
reviewed
Nov 4, 2024
Yes that makes sense 👍 This would probably require integrating other |
jtpio
reviewed
Nov 4, 2024
jupyterlab_git/handlers.py
Outdated
| @@ -1069,6 +1069,24 @@ async def post(self, path: str = ""): | |||
| self.finish(json.dumps(response)) | |||
|
|
|||
|
|
|||
| class GitSubModulesHandler(GitHandler): | |||
There was a problem hiding this comment.
Minor nitpick: should SubModule be spelled Submodule instead?
Looks like this is what the git docs use: https://git-scm.com/book/en/v2/Git-Tools-Submodules
Wondering about this, if we start exposing classes and other interfaces which include the word "submodule" in their name.
jtpio
reviewed
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1355.
Adds a display for submodules in the current repo inspired by the branch menu. Currently this just displays the submodules that are present and doesn't have any functionality. I figure how to handle the submodules and which functionality should be exposed should be discussed first.
Repo with no submodules:
Repo with submodules - collapsed:
Repo with submodules - expanded:
