Enforce path imports for MUI icons, upgrade to ESLint v8

[krassowski]

• Bumps eslint to v8 required to add enforcement rules for path imports on mui

• Enforces new icons - the CI correctly fails on first commit:

   /home/runner/work/jupyter-ai/jupyter-ai/packages/jupyter-ai/src/components/chat-settings.tsx
     223:16  warning  'e' is defined but never used  @typescript-eslint/no-unused-vars
   
   /home/runner/work/jupyter-ai/jupyter-ai/packages/jupyter-ai/src/components/settings/existing-api-keys.tsx
     9:1  error  '@mui/icons-material' import is restricted from being used. Please import icons using path imports, e.g. `import AddIcon from '@mui/icons-material/Add'`  no-restricted-imports
   
   /home/runner/work/jupyter-ai/jupyter-ai/packages/jupyter-ai/src/components/settings/model-fields.tsx
     29:18  warning  'exc' is defined but never used  @typescript-eslint/no-unused-vars
   
   /home/runner/work/jupyter-ai/jupyter-ai/packages/jupyter-ai/src/handler.ts
     34:14  warning  'error' is defined but never used  @typescript-eslint/no-unused-vars
   
   /home/runner/work/jupyter-ai/jupyter-ai/packages/jupyter-ai/src/index.ts
     63:14  warning  'e' is defined but never used  @typescript-eslint/no-unused-vars
   
   /home/runner/work/jupyter-ai/jupyter-ai/packages/jupyter-ai/src/slash-autocompletion.tsx
     5:1  error  '@mui/icons-material' import is restricted from being used. Please import icons using path imports, e.g. `import AddIcon from '@mui/icons-material/Add'`  no-restricted-imports
   
   ✖ 6 problems (2 errors, 4 warnings)
  

• Fixes jupyter-ai slows down initial page load significantly by downloading 4MB of icons it does not need #1221 - the size of the wheel should drop

Before	After

Before	After

[krassowski]

Adding some explanations to help with review

[krassowski]

There is a few more places where we should add these eslint rules:

• jupyter-scheduler (CC @andrii-i)
• jupyter-chat (CC @brichet)
• jupyterlab-git (related to Too many style frameworks? jupyterlab-git#1265) - this weights 15 MB compressed!

[dlqqq]

@krassowski Awesome work Mike! Thanks for diving deep into this and fixing the issue for Jupyter AI so quickly. You're a legend. 🎉

I'll reach out to @brichet and @andrii-i to let them know about your work here. They can help migrate this change over to their repos. I'll ask them to credit & co-author you on the PRs. 👍

[dlqqq]

@meeseeksdev please backport to 2.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 2.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 5b99b0fea04db63c01aa4670ab3ad223373cb9bf

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #1225: Enforce path imports for MUI icons, upgrade to ESLint v8'

4. Push to a named branch:

git push YOURFORK 2.x:auto-backport-of-pr-1225-on-2.x

5. Create a PR against branch 2.x, I would have named this PR:

"Backport PR #1225 on branch 2.x (Enforce path imports for MUI icons, upgrade to ESLint v8)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

[ellisonbg]

Thanks Mike, this is great!

[brichet]

Thanks @krassowski and @dlqqq for the ping, I'll see how to port it to jupyter-chat 👍

[krassowski]

Thanks for help with the backport! Looking forward to seeing a new 2.x version released :)

[dlqqq]

@krassowski Yes, we were planning on doing a release either today or tomorrow. Looking at the commit history, it seems like a patch release (v2.29.1) would suffice, since I think all of the changes are doc updates & bug fixes. Any objections?

[krassowski]

Sounds good to me!