Some fixes

jupyter · Oct 15, 2023 · da08cec · da08cec
1 parent 0bc28b3
commit da08cec
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/pyproject.toml b/pyproject.toml
@@ -136,6 +136,9 @@ version-cmd = "python scripts/bump_version.py --force"
 before-bump-version = [
     "npm install"
 ]
+before-build-npm = [
+    "npm run build"
+]
 
 [tool.pytest.ini_options]
 testpaths = "nbdime/tests"

diff --git a/scripts/bump_version.py b/scripts/bump_version.py
@@ -41,11 +41,11 @@ def bump(force: bool, spec: str) -> None:
     lerna_cmd = LERNA_CMD
     js_spec = spec
     if spec in ["alpha", "a", "beta", "b", "rc"]:
-        js_spec = " --force-publish prerelease"
+        js_spec = "--force-publish prerelease"
     elif spec == "release":
-        js_spec = " --conventional-commits --no-changelog --conventional-graduate"
+        js_spec = "--conventional-commits --no-changelog --conventional-graduate"
     else:
-        js_spec += f" --force-publish"
+        js_spec = f"--force-publish " + js_spec
 
     # bump the JS packages
     if force:
@@ -54,6 +54,9 @@ def bump(force: bool, spec: str) -> None:
     print(f"Executing '{lerna_cmd}'...")
     run(shlex.split(lerna_cmd), cwd=HERE, check=True, shell=True)
 
+    print(f"Changed made:")
+    run(["git", "diff"], cwd=HERE, check=True)
+
 
 if __name__ == "__main__":
     parser = argparse.ArgumentParser("bump_version", "Bump package version")