Migrate RefResolver to referencing.Registry #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbcarlos
force-pushed
the
migrate_to_referencing
branch
from
9e59b72 to
bd97003
Compare
hbcarlos
force-pushed
the
migrate_to_referencing
branch
from
3014417 to
d16ba81
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Julian
reviewed
Jul 21, 2023
Co-authored-by: Julian Berman <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I'll cut a release early next week. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jul 30, 2023
https://build.opensuse.org/request/show/1101394 by user bnavigator + dimstar_suse - Add jupyter_events-pr80-jsonschema-referencing.patch * gh#jupyter/jupyter_events#80 * Avoid test suite errors in consuming packages because of jsonschema DeprecationWarning - Remove workaround for rpmlint parser crash (forwarded request 1101393 from bnavigator)
|
Thank you for finishing the PR @blink1073! |
|
This PR seems to have broken things for various people in older versions of jsonschema: #99. I think we need to revisit this change. I'll see if I can devise a way to handle the transition to this new API more smoothly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warning:
See: https://github.com/jupyterlab/jupyter-collaboration/actions/runs/5533655455/jobs/10097501386?pr=175#step:6:97
This PR is ready, but merging will:
jsonschemato v4.18. See the changelog https://github.com/python-jsonschema/jsonschema/blob/main/CHANGELOG.rst#v4180referencinglibrary doesn't support it.