Skip to content

Commit

Permalink
fix lighthouse, closes #745 (#749)
Browse files Browse the repository at this point in the history
also fixes try-jupyter link, no more retro
  • Loading branch information
ivanov authored Dec 6, 2023
1 parent d3fb553 commit 3b010b5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lighthouserc.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"assertions": {
"categories:performance": ["error", { "minScore": 0.90 }],
"categories:accessibility": ["error", { "minScore": 0.95 }],
"categories:best-practices": ["error", { "minScore": 0.95 }],
"categories:best-practices": ["error", { "minScore": 0.90 }],
"categories:seo": ["error", { "minScore": 0.95 }]
}
}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
name: Built site ${{ github.run_number }}
path: ./_site
- name: Audit with Lighthouse
uses: treosh/lighthouse-ci-action@v8
uses: treosh/lighthouse-ci-action@v10
with:
configPath: ".github/workflows/lighthouserc.json"
temporaryPublicStorage: true
Expand Down
2 changes: 1 addition & 1 deletion try.html
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
description: The original web application for creating and sharing computational documents
src: try/python.svg
alt: Python logo - Launch Jupyter Notebook demo Binder
url: https://jupyter.org/try-jupyter/retro/notebooks/?path=notebooks/Intro.ipynb
url: https://jupyter.org/try-jupyter/notebooks/?path=notebooks/Intro.ipynb

- title: JupyterLite
description: JupyterLite (Wasm powered Jupyter) deployed as static GitHub Pages
Expand Down

0 comments on commit 3b010b5

Please sign in to comment.