-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error and fail start.sh on misconfiguration #1605
Conversation
I want to know your opinion and also need to fix the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm you make the log function exit on error. I'm not so fond of making its purpose be expanded to that while still being named just _log
.
I think I'd favor being explicit and including multiple exit
codes. One could also consider having separate non-zero exit codes for the errors when exiting to allow users recognize an error via the exit code as well.
Thanks for your suggestion, I will fix this. |
Hmmm... I think so, but I'm not that confident about it. Do we have default values for the environment variables etc that can cause trouble, forcing someone to explicitly configure something to avoid errors? That would be a signal to me that we have been too strict. |
I think the defaults are good, but I think there are many cases, where user sets one variable and forgets about another one (like chaning username requires |
Closing this one, I don't think I'm gonna have enough time in the nearest future to finish this PR. |
Fix: #1517