Skip to content

Update websocket-protocols documentation to reflect implementation #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

ark-1
Copy link
Contributor

@ark-1 ark-1 commented Apr 3, 2025

The doc didn't state that a WebSocket message has to start with the number of offsets, while the implementation was relying on that:

"""deserialize a message from a binary blog
Header:
4 bytes: number of msg parts (nbufs) as 32b int
4 * nbufs bytes: offset for each buffer as integer as 32b int
Offsets are from the start of the buffer, including the header.

@ark-1
Copy link
Contributor Author

ark-1 commented Apr 3, 2025

It seems I don't have the permissions to add the documentation label.

@Zsailer
Copy link
Member

Zsailer commented Apr 14, 2025

Thanks!

@Zsailer Zsailer merged commit 742c241 into jupyter-server:main Apr 14, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants