Skip to content

Commit

Permalink
Don't tag private package or pkg without version (#531)
Browse files Browse the repository at this point in the history
Co-authored-by: Steven Silvester <[email protected]>
  • Loading branch information
fcollonval and blink1073 authored Oct 17, 2023
1 parent 8bd91cc commit be0c23e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions jupyter_releaser/npm.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,9 @@ def tag_workspace_packages():
for path in _get_workspace_packages(data):
sub_package_json = path / "package.json"
sub_data = json.loads(sub_package_json.read_text(encoding="utf-8"))
# Don't tag package without version or private
if not sub_data.get("version", "") or sub_data.get("private", False):
continue
tag_name = f"{sub_data['name']}@{sub_data['version']}"
if tag_name in tags:
skipped.append(tag_name)
Expand Down

0 comments on commit be0c23e

Please sign in to comment.