Emit telemetry events on success and failure of the Create Job, Create Job Definition, Create Job from Job Definition hooks

[andrii-i]

Emit telemetry events on success and failure of the Create Job, Create Job Definition, Create Job from Job Definition hooks.

• Log object's body.name string is now following a new convention: org.jupyter.jupyter-scheduler.SOURCE.EVENT[.STATUS] (vs old convention org.jupyter.jupyter-scheduler.SOURCE.EVENT) where STATUS is either "success" or "failure"
• CreateJob now emits "create-job" or "create-job-definition" for EVENT instead of just "create" depending on if job or job definition is being created
• Log object's body now has optional detail parameter storing error message (or other string with event detail)

type EventLog = {
  body: { name: string; detail?: string };
  timestamp: Date;
};

• Improve error catching logic by catching errors as unknown type and using type guarding instead of assuming all errors caught would be of Error type (ts runtime error type) which is not guaranteed.
• Fix Emit telemetry events on create job forms #471

Emitted objects examples:

[andrii-i]

@3coins thank you for looking into this, implemented your comments re not logging an httpResponseCode. Also added improved error catching logic as discussed.

[JasonWeill]

"Unknown error occurred" is a generic message, but it may not inspire confidence. Do we have any idea about what sorts of errors might trigger the generic message? If so, can we provide any additional guidance? Something like, "An error occurred. Please try again."?

[andrii-i]

@JasonWeill thank you for looking into this. Any error / error object that does not have fields expected from es5 Error object would trigger the generic error message. Most probably to occur are connection failures, connection timeouts, third-party libraries throwing something else than es5 Error (other objects or just strings). So the message needs to be generic, I think the message that you proposed works well, updated the function to use it.

[JasonWeill]

Looks good, thanks!