Skip to content

Conversation

001ben
Copy link

@001ben 001ben commented Oct 12, 2025

Description

Implement fix for issue described in #963

Simplest fix is to not ad %%spark to any code containing _VSCODE_ as this code should only be intended for running locally.

See example VScode bootstrapping code here: #963

Checklist

  • Wrote a description of my changes above
  • Formatted my code with black
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • Added or modified unit tests to reflect my changes
  • Manually tested with a notebook
  • If adding a feature, there is an example notebook and/or documentation in the README.md file

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. kind:bug An unexpected error or issue with sparkmagic labels Oct 12, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 12, 2025
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @001ben! I don't have local set up to reproduce, but think this looks good.

I reached out to a few folks that have run into this issue to see if this fix works for them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug An unexpected error or issue with sparkmagic size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants