Adding in testing for screenshots #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@peterpeterparker how is first screenshot capture configed, so it has to run |
Contributor
peterpeterparker
left a comment
peterpeterparker
left a comment
There was a problem hiding this comment.
Can you remove the screenshot from the PR? We can generate those with the GitHub Action, I'll start it when ready.
Contributor
peterpeterparker
left a comment
peterpeterparker
left a comment
There was a problem hiding this comment.
Can you also revert the change regarding the dummy.spec? It's cleaner to remove it in another PR as we also have to remove its related template.
peterpeterparker
approved these changes
Oct 30, 2025
Contributor
peterpeterparker
left a comment
peterpeterparker
left a comment
There was a problem hiding this comment.
Looks good enough for me. I'll fix and improve it after merge.
Thanks for your contribution!
Contributor
Author
|
@peterpeterparker Thanks for allowing me to contribute. :) |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have written tests for checking in mail deposited and deposit-failed.