[openrewrite] add SanityCheck featuring tech.picnic.errorprone.refasterrules

[Pankraz76]

I hereby agree to the terms of the JUnit Contributor License Agreement.

---

Definition of Done

• There are no TODOs left in the code
• Method preconditions are checked and documented in the method's Javadoc
• Coding conventions (e.g. for logging) have been followed
• Change is covered by automated tests including corner cases, errors, and exception handling
• Public API has Javadoc and @API annotations
• Change is documented in the User Guide and Release Notes

relates to:

• Add rewrite support for errorprone.refasterrules #5002
• [openrewrite] add SanityCheck featuring CommonStaticAnalysis diffplug/spotless#2651

> Task :rewriteRun
Changes have been made to junit-platform-engine/src/main/java/org/junit/platform/engine/UniqueId.java by:
    tech.picnic.errorprone.refasterrules.CollectionRulesRecipes
        tech.picnic.errorprone.refasterrules.CollectionRulesRecipes$OptionalFirstCollectionElementRecipe
Changes have been made to junit-platform-engine/src/main/java/org/junit/platform/engine/support/hierarchical/DefaultParallelExecutionConfigurationStrategy.java by:
    tech.picnic.errorprone.refasterrules.BigDecimalRulesRecipes
        tech.picnic.errorprone.refasterrules.BigDecimalRulesRecipes$BigDecimalSignumIsPositiveRecipe
Changes have been made to junit-platform-launcher/src/main/java/org/junit/platform/launcher/EngineFilter.java by:
    tech.picnic.errorprone.refasterrules.CollectionRulesRecipes
        tech.picnic.errorprone.refasterrules.CollectionRulesRecipes$CollectionContainsRecipe
Changes have been made to junit-platform-launcher/src/main/java/org/junit/platform/launcher/listeners/OutputDir.java by:
    tech.picnic.errorprone.refasterrules.StreamRulesRecipes
        tech.picnic.errorprone.refasterrules.StreamRulesRecipes$StreamFindAnyIsPresentRecipe
Changes have been made to jupiter-tests/src/test/java/org/junit/jupiter/engine/discovery/predicates/IsTestFactoryMethodTests.java by:
    tech.picnic.errorprone.refasterrules.StreamRulesRecipes
        tech.picnic.errorprone.refasterrules.StreamRulesRecipes$EmptyStreamRecipe
Changes have been made to platform-tests/src/test/java/org/junit/platform/commons/support/conversion/ConversionSupportTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$EpochInstantRecipe
Changes have been made to platform-tests/src/test/java/org/junit/platform/engine/support/descriptor/AbstractTestSourceTests.java by:
    tech.picnic.errorprone.refasterrules.ClassRulesRecipes
        tech.picnic.errorprone.refasterrules.ClassRulesRecipes$ClassIsInstanceRecipe
Changes have been made to platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/OutputAttachingExtension.java by:
    tech.picnic.errorprone.refasterrules.ComparatorRulesRecipes
        tech.picnic.errorprone.refasterrules.ComparatorRulesRecipes$ReverseOrderRecipe
Changes have been made to platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/ModularUserGuideTests.java by:
    tech.picnic.errorprone.refasterrules.StreamRulesRecipes
        tech.picnic.errorprone.refasterrules.StreamRulesRecipes$StreamFilterSortedRecipe
Changes have been made to platform-tooling-support-tests/src/test/java/platform/tooling/support/tests/LocalMavenRepo.java by:
    tech.picnic.errorprone.refasterrules.ComparatorRulesRecipes
        tech.picnic.errorprone.refasterrules.ComparatorRulesRecipes$ReverseOrderRecipe
Please review and commit the results.
Estimate time saved: 50m

[Pankraz76]

kindly request feedback. Thanks.

[Pankraz76]

Suggested change

exclusions.addAll("**.ci-temp**")

[Pankraz76]

this is just an reminder of course you need to choose where to put this best.

• https://github.com/diffplug/spotless/blob/main/.github/workflows/ci.yml#L34

[Pankraz76]

this does change alot despite the initial effort. Every tool has its benefits making it win to the community.

[marcphilipp]

We have already decided against adopting OpenRewrite for our day-to-day build. I'd be open to looking at Error Prone's refaster with Picnic's rules, though, as discussed on the issue.