Don't run winrestcmd to restore windows #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you look at `:h winrestcmd` it says:
```
winrestcmd() *winrestcmd()*
Returns a sequence of |:resize| commands that should restore
the current window sizes. Only works properly when no windows
are opened or closed and the current window and tab page is
unchanged.
Example: >vim
let cmd = winrestcmd()
call MessWithWindowSizes()
exe cmd
```
We can't guarantee this, so don't try to restore windows.
Refs: neoclide/coc.nvim#4178 (comment)
Refs: vim-ctrlspace/vim-ctrlspace#306
Fixes: junegunn#74
Fixes: junegunn#83
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits (oldest to newest)
3490bc6 Don't run winrestcmd to restore windows
If you look at
:h winrestcmdit says:We can't guarantee this, so don't try to restore windows.
Refs: neoclide/coc.nvim#4178 (comment)
Refs: vim-ctrlspace/vim-ctrlspace#306
Fixes: #74
Fixes: #83