fix: parse JSON output in /v1/responses endpoint#614
Open
TipKnuckle wants to merge 1 commit intojundot:mainfrom
Open
fix: parse JSON output in /v1/responses endpoint#614TipKnuckle wants to merge 1 commit intojundot:mainfrom
TipKnuckle wants to merge 1 commit intojundot:mainfrom
Conversation
DiegoRBaquero
approved these changes
Apr 7, 2026
b8886d9 to
7a91249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/v1/responsesendpoint was missing theparse_json_output()post-processing step that/v1/chat/completionsalready performs. Whenresponse_formatis specified and the model wraps JSON in markdown code blocks (common when xgrammar is unavailable), the raw markdown was returned to the client instead of parsed JSON.Changes
parse_json_output()call increate_response()(non-streaming/v1/responses) between tool call extraction and output building, matching the existing pattern increate_chat_completion().Closes #613