Fixing a 'division by zero' error in skfeature/utility/mutual_information.py #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 1, 2020 16:54
Thif fix prevents from a 'division by zero' error when H(f1)+H(f2) is equal to 0.
This reverts commit 60944e9.
This fix prevents from a 'division by zero' error when H(f1)+H(f2) is equal to 0.
|
I had the same problem here. Glad to see this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was using the CFS method in my thesis project at college and it triggered a"division by zero' error when calculating the symmetrical uncertainty. Given the formula: su(f1,f2) = 2*IG(f1,f2)/(H(f1)+H(f2)), when H(f1)+H(f2) is equal to zero, it triggers a "division by zero" error.
Best regards,
Jose D.