forked from mrc-ide/tfpscanner
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save sina-plot .rds files #17
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1ef0d7a
env: bump roxygen version
russHyde 2073e9a
refac: separate creation from saving of sina-cluster plot
russHyde 9f9005f
feat: save sina-plot as ggplot2 in .rds file
russHyde 953a5cf
chore: bump version
russHyde fb33244
feat: treeview() user can specify sina-plot output format (rds or html)
russHyde 364dcaa
feat: allow saving sina-cluster plots as both html and rds
russHyde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
Package: tfpscanner | ||
Title: Transmission fitness polymorphism scanner | ||
Version: 0.2.0 | ||
Date: 2022-11-09 | ||
Version: 0.2.1 | ||
Date: 2022-12-06 | ||
Author: Erik Volz, Olivia Boyd | ||
Maintainer: Erik Volz <[email protected]> | ||
Description: A pipeline for scanning a SARS-CoV-2 phylogeny for clades with outlying growth | ||
|
@@ -39,5 +39,5 @@ Remotes: | |
SystemRequirements: libopenmpi-dev | ||
Encoding: UTF-8 | ||
License: MIT + file LICENSE | ||
RoxygenNote: 7.2.1 | ||
RoxygenNote: 7.2.2 | ||
Config/testthat/edition: 3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,7 @@ generalised | |
ggiraph | ||
ggplot | ||
ggtree | ||
htmlwidget | ||
htmlwidgets | ||
ide | ||
Ile | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this allow saving both as an rds and as an html?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Maybe not yet. If they have produced a cluster-sina ggplot object, then they can save that as an .rds or an .html by calling
save_sina_plot(ggobj, ..., output_format = "rds")
orsave_sina_plot(ggobj, ..., output_format = "html")
.But a typical user would be calling the
treeview()
workflow, rather than the internals. I can add asina_output_format
parameter totreeview()
so that they can calltreeview(input_env_rds, sina_output_format = "rds")
ortreeview(input_env_rds, sina_output_format = "html")
.Will do that now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my misunderstanding. As both "html" and "rds" in the same runthrough? That isn't implemented here, but can easily be done. Give me a minute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been rewritten. Now the user can save cluster-sina plots as either .rds, .html or both (default: both). And they can specify which format to output the cluster-sina plots in the arguments to
treeview()
.So
treeview(input_env_rds)
will output both .rds and .html versions ofsina-logistic_growth_rate
andsina-clock_outlier
to "./treeview/".