Skip to content

Fix TestBibleAIClient_GetPassage_Romans3 test expectation#385

Merged
julwrites merged 1 commit into
stagingfrom
fix/bible-ai-test-newlines-1938692514443939009
May 1, 2026
Merged

Fix TestBibleAIClient_GetPassage_Romans3 test expectation#385
julwrites merged 1 commit into
stagingfrom
fix/bible-ai-test-newlines-1938692514443939009

Conversation

@julwrites
Copy link
Copy Markdown
Owner

Fixes TestBibleAIClient_GetPassage_Romans3 failing test by updating expectations to match the cleanHTML logic which normalizes newlines to spaces.


PR created automatically by Jules for task 1938692514443939009 started by @julwrites

The `cleanHTML` function normalizes newlines to spaces, which caused the
`TestBibleAIClient_GetPassage_Romans3` test to fail since it expected
the extracted text to retain its original newlines.

This commit updates the expected text in the test to compare against a
space-normalized string instead.

Co-authored-by: julwrites <[email protected]>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Code Coverage Report

Component Metric Percentage
Backend Total 84.2%
Frontend Statements 72.84%
Frontend Branches 58.91%
Frontend Functions 69.6%
Frontend Lines 75.4%

@julwrites julwrites merged commit 4807ce1 into staging May 1, 2026
5 checks passed
@julwrites julwrites deleted the fix/bible-ai-test-newlines-1938692514443939009 branch May 1, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant