🎨 Palette: Add context-aware ARIA labels to NoteCard icon buttons#378
🎨 Palette: Add context-aware ARIA labels to NoteCard icon buttons#378julwrites wants to merge 3 commits into
Conversation
This commit adds `aria-label` attributes to the "Ask AI", "Share", and "Delete" icon-only `<Button>`s in the `NoteCard` component. By interpolating the note's title (or "Untitled Note") into the label, it ensures screen reader users have clear, context-aware information when navigating through lists of note cards, preventing ambiguity between identical icon buttons on different cards. Co-authored-by: julwrites <18639913+julwrites@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Code Coverage Report
|
This commit adds `aria-label` attributes to the "Ask AI", "Share", and "Delete" icon-only `<Button>`s in the `NoteCard` component. By interpolating the note's title (or "Untitled Note") into the label, it ensures screen reader users have clear, context-aware information when navigating through lists of note cards, preventing ambiguity between identical icon buttons on different cards. Fixes failing tests and improves branch coverage for the component. Co-authored-by: julwrites <18639913+julwrites@users.noreply.github.com>
Removed the unused `rerender` variable that was causing a linting error (`'rerender' is assigned a value but never used @typescript-eslint/no-unused-vars`) and consequently failing the CI pipeline. Co-authored-by: julwrites <18639913+julwrites@users.noreply.github.com>
1 participant
💡 What: Added context-aware
aria-labelattributes to the "Ask AI", "Share", and "Delete" icon-only buttons in theNoteCardcomponent.🎯 Why: To improve accessibility for screen reader users. When navigating a list of identical cards, generic "Delete" labels become ambiguous. Adding the item's title (e.g., "Delete Genesis Study") provides necessary context.
♿ Accessibility: Ensures interactive elements have descriptive names, meeting WCAG guidelines for non-text content and focusable elements in repeated lists.
PR created automatically by Jules for task 4820434883245162918 started by @julwrites