fixed finding element on array

julianCast · Feb 28, 2017 · 5784358 · 5784358
1 parent 7649081
commit 5784358
Showing 1 changed file with 13 additions and 12 deletions.
diff --git a/Controller/api/getStory.php b/Controller/api/getStory.php
@@ -18,7 +18,7 @@
 $placeName = strtolower($_POST['place']);
 
 // Stories already read by user
-$readStories = $_POST['read_stories'];
+ $readStories = $_POST['read_stories'];
 // Language user 
 $lang = $_POST['lang'];
 
@@ -67,10 +67,10 @@
 }
 
 // Get random story from DB
-if ($readStories) {
+if (count($readStories) > 0) {
   do {
     $rndStory = Historia::random($lang);
-  } while (!_isStoryUnique($rndStory->id));
+  } while (array_search($rndStory->id, $readStories) != FALSE);
 } else {
   $rndStory = Historia::random($lang);
 }
@@ -157,18 +157,19 @@
       "title" => $title,
       "story" => $storyText,
       "author" => $author,
-      "storyID" => $rndStory->id
+      "storyID" => $rndStory->id,
+      "test" => $readStories
   );
   header('Content-Type: application/json');
 
   echo json_encode($arrayHistoria);
 
 // Check if @id parameter is found in array
-  function _isStoryUnique($id) {
-    foreach ($readStories as &$key) {
-      if ($id != $key) {
-        return true;
-        break;
-      } 
-    }
-  }
+  // function _isStoryUnique($id) {
+  //   foreach ($readStories as &$key) {
+  //     if ($id != $key) {
+  //       return true;
+  //       break;
+  //     } 
+  //   }
+  // }