Initial attempt to port 'reachability' command from serf to consul. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
command/agent/agent.go
Outdated
Author
There was a problem hiding this comment.
Let's clean up the jfses and replace them with something more meaningful (I think agent makes sense in this case).
Author
|
This looks really good! Let's add some tests and docs, and then I think this is ready to PR to Consul proper. |
added 9 commits
November 2, 2015 10:43
…s, functions, and log messages are appropriately named.
…s - 'reachability' does not work on servers, only clients.
… client configurations.
…mber of missing acks from live nodes equals the number of acks from non-live nodes.
jsullivan3
force-pushed
the
reachability
branch
from
0143cd9 to
ad650d2
Compare
…t 'memberlist' member list for node info.
Add 'ping' command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn this into a pull request in John's repo to make it easier to see the diff.