Fix bug in async publisher

jstachio · Jan 10, 2024 · d30ca38 · d30ca38
1 parent 56dc355
commit d30ca38
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/core/src/main/java/io/jstach/rainbowgum/LogProperties.java b/core/src/main/java/io/jstach/rainbowgum/LogProperties.java
@@ -676,7 +676,7 @@ default Property<T> build(String key) {
 			String fqn = fullyQualifiedKey(key);
 			if (!fqn.startsWith(LogProperties.ROOT_PREFIX)) {
 				throw new IllegalArgumentException(
-						"Property key should start with: '" + LogProperties.ROOT_PREFIX + "'");
+						"Property key should start with: '" + LogProperties.ROOT_PREFIX + "'. key = " + key);
 			}
 			return new Property<>(this, key);
 		}
@@ -689,7 +689,7 @@ default Property<T> build(String key) {
 		 * @return property.
 		 */
 		default Property<T> buildWithName(String key, String name) {
-			String fqn = LogProperties.interpolateKey(name, Map.of(NAME, name));
+			String fqn = LogProperties.interpolateKey(key, Map.of(NAME, name));
 			return build(fqn);
 		}
 

diff --git a/core/src/main/java/io/jstach/rainbowgum/publisher/BlockingQueueAsyncLogPublisher.java b/core/src/main/java/io/jstach/rainbowgum/publisher/BlockingQueueAsyncLogPublisher.java
@@ -118,9 +118,8 @@ public void run() {
 
 		private void drain() {
 			try {
-				int count = queue.drainTo(fake, bufferSize);
-				assert count == fake.size;
-				append(buffer, count);
+				queue.drainTo(fake, bufferSize);
+				append(buffer, fake.size);
 			}
 			finally {
 				fake.reset();

diff --git a/core/src/test/java/io/jstach/rainbowgum/RainbowGumTest.java b/core/src/test/java/io/jstach/rainbowgum/RainbowGumTest.java
@@ -77,9 +77,8 @@ void testFormatterBuilder() throws Exception {
 			r.publisher(PublisherProvider.async().build());
 			r.appender(sysout);
 			r.level(Level.WARNING, "stuff");
-		}).build()) {
+		}).build().start()) {
 
-			gum.start();
 			gum.router().log("stuff", Level.INFO, "Stuff", null);
 			gum.router().log("stuff", Level.ERROR, "bad", null);