Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bun error on calling jsr add twice #36

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

nakasyou
Copy link
Contributor

@nakasyou nakasyou commented Mar 2, 2024

If you merged this, I think you may able to close #35.

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2024

CLA assistant check
All committers have signed the CLA.

src/commands.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, let's add a test for this to ensure that we don't ever regress on this and then it's ready to be merged 👍

Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks for adding the test 👍

@marvinhagemeister marvinhagemeister changed the title fix: second jsr add fails fix: bun error on calling jsr add twice Mar 5, 2024
@marvinhagemeister
Copy link
Collaborator

Looks like the PR is not formatted correctly. Running deno fmt locally should resolve this.

@nakasyou
Copy link
Contributor Author

nakasyou commented Mar 5, 2024

Hi @marvinhagemeister, thank you for feedback!
I ran deno fmt.

I was confused about the formatter. There is a possibility that Other contributors will be confused just like me, so it might be a good idea to write description of formatter in a README.

@marvinhagemeister marvinhagemeister merged commit ef97c32 into jsr-io:main Mar 5, 2024
5 checks passed
@nakasyou nakasyou deleted the fix/bun-jsr-add branch March 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: After the second time bunx jsr add ... is failed
4 participants