fix: inconsistency and grammar in help messages #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
morinokami
commented
Feb 28, 2024
•
morinokami
commented
- Add periods for consistency where missing.
- Fix grammer.
- Update jsr to JSR.
rojvv
reviewed
Feb 29, 2024
src/bin.ts
Outdated
Comment on lines
39
to
40
| ["i, install, add", "Install one or more jsr packages."], | ||
| ["r, uninstall, remove", "Remove one or more jsr packages."], |
There was a problem hiding this comment.
We also need to figure out if the official casing is jsr or JSR.
There was a problem hiding this comment.
Yeah, thanks for spotting this. I checked the docs and it looks like the official casing is JSR, so this should be corrected as well.
rojvv
reviewed
Feb 29, 2024
rojvv
reviewed
Feb 29, 2024
src/bin.ts
Outdated
Comment on lines
31
to
32
| ["jsr add @std/log", 'Install the "@std/log" package from jsr.io.'], | ||
| ["jsr remove @std/log", 'Remove the "@std/log" package from the project.'], |
There was a problem hiding this comment.
Personal suggestion, feel free to ignore.
Suggested change
| ["jsr add @std/log", 'Install the "@std/log" package from jsr.io.'], | |
| ["jsr remove @std/log", 'Remove the "@std/log" package from the project.'], | |
| ["jsr add @std/log", "Install the package @std/log."], | |
| ["jsr remove @std/log", "Remove the package @std/log from the project."], |
morinokami
changed the title
|
@roj1512 Thanks for your suggestions! But I am not sure if these changes are appropriate, and I feel they are outside the scope of this PR, so I will leave it to the maintainers to decide if they should be merged. |
|
|
|
Thanks for the PR, please sign the CLA so we can merge it :) |
|
@bartlomieju Signed it! 😁 |
Co-authored-by: Roj [roːʒ] <[email protected]>
marvinhagemeister
approved these changes
Feb 29, 2024
marvinhagemeister
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.