Update Sidebar.jsx for proper displaying External links icon in dark … #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
benjagm
approved these changes
Oct 2, 2024
|
Congratulations, @Vishv0407 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
DhairyaMajmudar
added
the
Hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mode
What kind of change does this PR introduce?
bugfix: On Sidebar of Specification/docs page, redirect icon is not visible in dark mode so i changed its css property for toggle the theme
Issue Number:
Screenshots/videos:
Previous:
Now:
If relevant, did you update the documentation?
Summary
This bug affects the visibility and styling of the redirect icon in the left navbar when dark mode is enabled. The icon does not have appropriate styles for dark mode, causing it to either be invisible or inconsistent with the overall theme. The expected behavior is that the icon should have a well-defined style that ensures its visibility and fits seamlessly with the dark mode design.
Does this PR introduce a breaking change?
No