Update content location by transfer and add information #975
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
.gitignore
Outdated
| #local file | ||
| .env | ||
| /node_modules | ||
|
|
.gitignore
Outdated
| #local file | ||
| .env | ||
| /node_modules | ||
|
|
There was a problem hiding this comment.
Please remove these changes, we already have .env and /node_modules in this file
| #local file | |
| .env | |
| /node_modules |
Co-authored-by: Zeel Rajodiya <[email protected]>
|
@jagpreetrahi Thank you for your contribution but it seems like there's PR #963 is performing the same things done in this one. Can you pls. tell if anything is out of scope for improvement done in this, if not can you pls. mind closing it |
|
Hi @DhairyaMajmudar, thank you for your response! In this issue, I aimed to provide additional details and examples, especially for non-string types, that are not currently mentioned in the official documentation. I also compared it with PR #963, and while the intention is similar, my contribution includes extra relevant information that could be helpful for developers. If these changes are useful, feel free to merge them; otherwise, I'm happy to close the issue. Please don't hesitate to reach out if any other issues arise that I can help with—I’d love to continue contributing to this organization! |
|
Hi @jagpreetrahi . Please apologize me as I am responsible of 2 contributors working on the same issue by mistake. You did a great work, however most of the discussion is happening in #963 therefore we are going to focus on that one. I'd like to thank you for your time and efforts and we'd like you to join that discussion as PR reviewer therefore all the knowledge and experience you gained with this contribution will be used to make sure the other PR is great. |
|
Hi @benjagm, hope you’re doing well ! No need to worry about any of it— I appreciate the opportunity to review and discuss #963 further. I’m working with the team to make improvements to the docs for our organization, aiming to get it done as soon as possible. Let’s keep collaborating to make this even better |
What kind of change does this PR introduce?
This PR allows content to be updates and reorganizes the content of the Markdown files used in the JSON website.
Issue Number:
Pick one of the below options. Please remove those which don't apply.
Screenshots/videos:
If relevant, did you update the documentation?
Yes, the documentation has been updated to reflect the changes made in the Markdown files.
Local Server
Summary
This change focuses on updating and moving content between Markdown files to enhance the clarity and relevance of information presented on the website. The motivation behind these updates is to provide a more cohesive user experience by reorganizing related content into more logical sections.
Issue - 187
Does this PR introduce a breaking change?
No, this PR does not introduce any breaking changes. The website's structure and functionality remain intact, ensuring a smooth user experience.