Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools]: Add environment filter/search options to tools #959

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

DarhkVoyd
Copy link
Member

@DarhkVoyd DarhkVoyd commented Sep 20, 2024

What kind of change does this PR introduce?
This PR aims to add environment filter/search options to the new tooling data page at /tools as part of ongoing process to gather and iterate over community feedback to improve the page and minimise friction in JSON Schema tool adoption.

Issue Number:
Related: #928

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@DarhkVoyd DarhkVoyd requested a review from a team as a code owner September 20, 2024 07:35
Copy link

github-actions bot commented Sep 20, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview ae01192

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b8fa129) to head (ae01192).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #959   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjagm
Copy link
Collaborator

benjagm commented Sep 23, 2024

Hi @DarhkVoyd can we change the order of the filter options to position Dialect before license as part of this change? I'll suggest this order:

  • Language
  • Tooling Type
  • Environment
  • Dialect
  • License

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks DV. Looks good!

@benjagm benjagm merged commit 9b27076 into json-schema-org:main Oct 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants