Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Tour of JSON Schema to the website #859

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Adding Tour of JSON Schema to the website #859

merged 2 commits into from
Aug 14, 2024

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Aug 12, 2024

Summary

This PR adds Tour of JSON Schema to the website by:

  • Add the tour to the getting started section.
  • Creating a new landing page for the getting started section with the links for the getting started guide or the tour.
  • The getting started button of the landing page now redirects to the new getting started landing with a button to access the tour.

Does this PR introduce a breaking change? No

@benjagm benjagm requested a review from a team as a code owner August 12, 2024 16:44
Copy link

github-actions bot commented Aug 12, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview ec37ca5

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5a7f2ff) to head (ec37ca5).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #859   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           20        20           
  Branches        12        12           
=========================================
  Hits            20        20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pages/learn/index.page.tsx Outdated Show resolved Hide resolved
@JeelRajodiya
Copy link
Member

Just left a small suggestion for the description. Otherwise we are good to go 🚀

@benjagm benjagm removed the request for review from a team August 14, 2024 15:39
@benjagm benjagm merged commit 96305fb into main Aug 14, 2024
9 checks passed
@benjagm benjagm deleted the benjagm-add-tour branch August 14, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants