-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing guide #851
Contributing guide #851
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 1
Lines ? 20
Branches ? 12
========================================
Hits ? 20
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Hi Valeria I see in this PR content who belongs to multiple issues, like #790 and that is not ideal. You should work in different branches submitting changes separated from each other. Specifically, for contributing to the JSON Schema docs I am expecting the changes to be included as part of the existing contributing guide. Later we can work on using a symlink to show that markdown file as a page (As we do with sponsors and the code of conduct md files. I can help to implement this ). The contributing information we show in the website should cover all the possible contribution paths and not only the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments here:
What kind of change does this PR introduce?
This PR adds a Contributing guide for the JSON Schema documentation.
Issue #830
Screenshots/videos:
If relevant, did you update the documentation?
Summary
This PR explains the workflows and expectations when contributing to documentation, making it easier for technical writers to find their way in the JSON Schema project.
Does this PR introduce a breaking change? No, it doesn't