-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adding keywords page #844
Conversation
Hey there 👋! Are you an implementer of a new JSON Schema related tool, or an interested user submitting a tool you like? Someone will review your pull request shortly. In the interim, if you haven't already, there's a few things you might be interested in reviewing or confirming:
If you have any questions, any feedback, or need help with the submission process, don't hesitate to reach out. |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first version! Congrats. I left some comments to make some adjustments but we are very close!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 1
Lines ? 20
Branches ? 12
========================================
Hits ? 20
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Amazing job @DhairyaMajmudar !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a really useful resource!
I do worry about it getting out of date as the website evolves. Is there a checklist for adding things the to website? Having something that reminds to check if this index needs to be updated would be a good idea.
What kind of change does this PR introduce?
Adding new keywords page
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
N/A
Summary
A new keywords page is added.