Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yarn) : migrated yarn to modern yarn berry #842

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

aialok
Copy link
Member

@aialok aialok commented Aug 3, 2024

What kind of change does this PR introduce?

  • Migrate Yarn to modern Yarn
  • Update workflow to work with modern Yarn
  • Fixes CodeCov failing workflow
  • Update ci.yml to run on push workflow because CodeCov coverage needs to be updated with base branch
  • Add some missing peer deps for Cypress/coverage
  • Add docs for corepack

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

Summary

  • This PR will migrate Yarn to use modern Yarn Berry stable version ([email protected]) and update all workflows needed to run with modern Yarn.
  • CodeCov coverage was failing due to use of old version. In this PR, it is upgraded to stable version.
  • We also need to update code coverage of main default branch. Now our CI workflow will run for pushes too.
  • Our CLI was giving some warnings for missing peer dependencies for Cypress/code coverage. These are now fixed.

Does this PR introduce a breaking change?

@aialok aialok requested a review from a team as a code owner August 3, 2024 15:48
Copy link

codecov bot commented Aug 3, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@aialok aialok added the GSoC Google Summer of Code related label Aug 3, 2024
Copy link

github-actions bot commented Aug 5, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview aa1928a

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Alok. Thanks!

@benjagm benjagm merged commit 8710923 into json-schema-org:main Aug 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants