Adding feedback to improve the messaging and illustration of What is JSON Schema #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying website with
|
| Latest commit: |
d9ca222
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5ab42266.website-2v2.pages.dev |
| Branch Preview URL: | https://benjagm-what-is-json-schema.website-2v2.pages.dev |
DavidBiesack
approved these changes
May 30, 2024
|
@Relequestual We have incorporated in this PR your feedback from #655 review. |
DavidBiesack
approved these changes
Jun 2, 2024
Relequestual
requested changes
Jun 4, 2024
Co-authored-by: Ben Hutton <[email protected]>
Julian
reviewed
Jun 4, 2024
Julian
reviewed
Jun 4, 2024
Co-authored-by: Greg Dennis <[email protected]>
|
Thanks everyone!! I just pushed a new version addressing all the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After merging #679 we receive great feedback from @DavidBiesack and this PR is intended to address David's suggestions.
Does this PR introduce a breaking change?
No