fix: updated icon alts
#723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow all icons had an `alt` text of `eye icon` even if they were different icons.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
|
Congratulations, @1p22geo for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
Akshaybagai52
pushed a commit
to Akshaybagai52/website
that referenced
this pull request
Jun 2, 2024
Somehow all icons had an `alt` text of `eye icon` even if they were different icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update the alt text of icons so that the page is more accessible
Issue Number:
I don't think there is any
Screenshots/videos:
This is how the page looks like if you disable JS in the browser.
If relevant, did you update the documentation?
I don't think it is relevant.
Summary
Somehow all icons had an
alttext ofeye iconeven if they were different icons.Does this PR introduce a breaking change?
no.