Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve draft info render for arrays-additional items #651

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Improve draft info render for arrays-additional items #651

merged 1 commit into from
Apr 15, 2024

Conversation

srini047
Copy link
Contributor

What kind of change does this PR introduce?

Bugfix of render the draft specific info of UJS arrays.

Issue Number:

Screenshots/videos:

image

@srini047 srini047 requested a review from a team as a code owner April 14, 2024 14:13
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Looks good to me. Thanks for fixing this!

@benjagm benjagm requested a review from gregsdennis April 15, 2024 05:10
Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendering looks good. I think in a separate PR we need to reconsider the wording of those notes. It's not always about tuples.

@benjagm benjagm merged commit 9dd2fae into json-schema-org:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UJS arrays reference needs content work
3 participants