Fix some inconsistent indentation #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
gregsdennis
reviewed
Apr 11, 2024
| "state": { "type": "string" } | ||
| "street_address": { "type": "string" }, | ||
| "city": { "type": "string" }, | ||
| "state": { "type": "string" } | ||
| }, |
There was a problem hiding this comment.
This should be pulled back by two spaces.
| @@ -263,10 +262,9 @@ the subschema on the highlighted part of the following schema. | |||
| "$id": "https://example.com/schemas/address", | |||
| "type": "object", | |||
| "properties": { | |||
| "street_address": | |||
| { | |||
| "street_address": { | |||
| "$anchor": "street_address", "type": "string" | |||
There was a problem hiding this comment.
Each property should have its own line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix (indentation correction)
Issue Number:
N/A
Screenshots/videos:
N/A
If relevant, did you update the documentation?
https://json-schema.org/understanding-json-schema/structuring
Summary
I was reading the structuring doc and found the indentation in a couple of the code examples confusing. I've adjusted it to be more like other examples of the address schema in the doc, making easier to read.
Does this PR introduce a breaking change?
I hope not!