Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: all invisible table headers #625

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fixes: all invisible table headers #625

merged 2 commits into from
Apr 8, 2024

Conversation

VivekJaiswal18
Copy link
Contributor

What kind of change does this PR introduce?
Bugfix

Issue Number:

Screenshots/videos:

issue:

hha.mp4

fix:

hhb.mp4

Does this PR introduce a breaking change?

No

@VivekJaiswal18 VivekJaiswal18 requested a review from a team as a code owner April 1, 2024 18:17
DarhkVoyd
DarhkVoyd reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@DarhkVoyd DarhkVoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
Since you are fixing the text color for a better experience in the dark mode, how about also changing the background of the cell to better fit with the dark mode.

DhairyaMajmudar
DhairyaMajmudar reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls. also, remove extra Tailwind classes from the line 298 to remove these vs code warnings : )

image

benjagm
benjagm approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@benjagm benjagm merged commit ccc1c04 into json-schema-org:main Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarhkVoyd DarhkVoyd DarhkVoyd left review comments

@DhairyaMajmudar DhairyaMajmudar DhairyaMajmudar left review comments

@benjagm benjagm benjagm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Table heading not visible in dark mode
4 participants
@VivekJaiswal18 @benjagm @DarhkVoyd @DhairyaMajmudar