Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright Added in the Footer Section. #618

Merged
merged 5 commits into from
Apr 1, 2024
Merged

Copyright Added in the Footer Section. #618

merged 5 commits into from
Apr 1, 2024

Conversation

its-VinayKumar
Copy link
Contributor

@its-VinayKumar its-VinayKumar commented Mar 28, 2024

What kind of change does this PR introduce?

Issue Number:
#573
Closes #573

Screenshots/videos:


Screenshot (209)
Screenshot (214)

If relevant, did you update the documentation?

Summary
It is the updated PR of Copyright issue.

@its-VinayKumar its-VinayKumar requested a review from a team as a code owner March 28, 2024 21:03
@its-VinayKumar
Copy link
Contributor Author

its-VinayKumar commented Mar 28, 2024

@benjagm It is latest PR with file changes on it, Please Merge the PR :)

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes to accelerate the approval.

Things I fixed:

  • Avoid the declaration of a new css class in globals.css and use inline css using tailwind css.
  • Remove changes added to this PR but part of different issues.
  • Added an improvement for small devices to produce a line break between Copyright © 2024 JSON Schema and All rights reserved when it makes sense.

@benjagm benjagm merged commit 90ca515 into json-schema-org:main Apr 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Website's Copyright is not mentioned within the Footer Section.
2 participants