Fixed overflow of text in validators on Obsolete Page #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjagm
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Great first set of changes. We need to add some more:
- The column about should be hidden for small devices like we do in the tooling page.
- I realized that this page was showing the sidebar but it is not required in this case. Please see how the index.page.tsx of the implementations folder works to follow here a similar approach and make sure we don't show the sidebar.
|
Hey @benjagm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A bug fix
Issue Number:
#586
Closes #586
Summary
Fixed the text overflow in validators on Obsolete Page by making the required CSS changes.
Does this PR introduce a breaking change?
No