Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed smooth scroll for specified links #590

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

VivekJaiswal18
Copy link
Contributor

What kind of change does this PR introduce?
Bugfix

Issue Number:

Screenshots/videos:

spec.mp4
overview.mp4

If relevant, did you update the documentation?
No

Summary

I have thoroughly checked if there is any conflicting uri/anchor tag/link, and as I have added a new anchor tag there will be no issue with backwards compatibility.

Does this PR introduce a breaking change?
No

@VivekJaiswal18 VivekJaiswal18 requested a review from a team as a code owner March 23, 2024 23:05
@VivekJaiswal18
Copy link
Contributor Author

@benjagm Please have a look, also added small description for reference.
I don't think any compatibility issue will happen but If any issue rises please let me know.
Thank you

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks!!

@benjagm benjagm merged commit f5b8d3a into json-schema-org:main Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Broken alignment of fragment in Specification section
2 participants