Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #website and slack link to feedback #580

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

Sahil-Shadwal
Copy link
Contributor

@Sahil-Shadwal Sahil-Shadwal commented Mar 22, 2024

What kind of change does this PR introduce?
This modifies the feedback response now it says :
Thanks for the feedback! See it on #website in Slack for further discussion.

Issue Number:

Screenshots/videos:
Screenshot from 2024-03-22 13-08-53

If relevant, did you update the documentation?

Summary

It improves feedback response for better user experience.

Does this PR introduce a breaking change?
No it doesn't.

@Sahil-Shadwal Sahil-Shadwal requested a review from a team as a code owner March 22, 2024 06:29
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just leave 2 comments!

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing LGTM 💯

@Sahil-Shadwal Sahil-Shadwal requested a review from benjagm March 30, 2024 19:03
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for this!!

@benjagm benjagm merged commit 7830e3f into json-schema-org:main Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Modify the response of the feedback form
3 participants