Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue with workflow to Greeting the new contributor #504

Closed
wants to merge 4 commits into from
Closed

Fix: Issue with workflow to Greeting the new contributor #504

wants to merge 4 commits into from

Conversation

Sahil-Shadwal
Copy link
Contributor

What kind of change does this PR introduce?
This fixed unnecessary Greetings to the new contributors.

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?
Not relevant hence no need to update the docs.

Summary
The main goal was to reduce unnecessary greeting comments, to keep the comment section clean.

Does this PR introduce a breaking change?
No

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pr. Left one comment.

@@ -199,4 +199,3 @@ border-radius: 4px; */
.mt-custom {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just ran these two as suggested in readme
yarn run format:fix
yarn run lint:fix

I guess there was some linting issue and it got fixed , should i revert that ?

@Sahil-Shadwal
Copy link
Contributor Author

hey i am going to open new pr , this got messier due to prettier extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Issue with workflow to Greeting the new contributor
2 participants