Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: draft behaviour and hydration error #498

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

AdityaSingh-02
Copy link
Contributor

What kind of change does this PR introduce?

Issue Number:

Screenshots/videos:

Before

Screen.Recording.2024-03-10.at.9.41.58.AM.mov

After

Screen.Recording.2024-03-10.at.9.54.39.AM.mov

If relevant, did you update the documentation?

Summary
1- Here I have fixed the behavior of the table before it was taking full width and there was not any overflow or width property.
2- I have also made changes in the release-notes.md, which was causing a hydration error and I made a change at line number 466. it was taking more than required width.

Does this PR introduce a breaking change?

  • No

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls. remove the changes from yarn.lock and package.lock.json file since it is increasing the pr size.

@DhairyaMajmudar
Copy link
Member

Also it will be good for users, if instead of applying overflow-auto , the 1x2 grid is converted into 2x1 grid as suggested in the issue : )

Copy link
Member

@JeelRajodiya JeelRajodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you deleted the entire yarn.lock file.
As @DhairyaMajmudar mentioned, please leave the yarn.lock file as it is ( do not make any changes nor delete it )

@AdityaSingh-02
Copy link
Contributor Author

I think you deleted the entire yarn.lock file. As @DhairyaMajmudar mentioned, please leave the yarn.lock file as it is ( do not make any changes nor delete it )

Yup, I deleted it completely(by mistake), I should have stashed changes before pushing, I will take care of it from next time, Till then what should I do? will it affect the code? since I have not added any new dependencies, the file has minor changes it should not affect code base(I might be wrong here)

@aialok
Copy link
Member

aialok commented Mar 10, 2024

@AdityaSingh-02, a better approach would be to clone the project from the beginning using Yarn and leave this as it is. Check out the README.md for more details.
Then, create a new branch with the same name as the one you used in this PR and make the required changes or you can copy-paste your work and force-push the changes to this PR branch. This will solve all your problems. Before cloning the project again, make sure you have fetched the latest upstream in your fork repository to avoid any conflict.

@AdityaSingh-02
Copy link
Contributor Author

Heyy @JeelRajodiya I have reverted the changes, could you look at it again?

@JeelRajodiya
Copy link
Member

@AdityaSingh-02, are you using npm ?

@AdityaSingh-02
Copy link
Contributor Author

@AdityaSingh-02, are you using npm ?

yup

@JeelRajodiya
Copy link
Member

@AdityaSingh-02, are you using npm ?

yup

yes, that is why the yarn.lock file is being modified.

You'll have use yarn instead of npm as suggested by @aialok in this comment

@AdityaSingh-02
Copy link
Contributor Author

@AdityaSingh-02, are you using npm ?

yup

yes, that is why the yarn.lock file is being modified.

You'll have use yarn instead of npm as suggested by @aialok in this comment

okay got it, so should I do everything again or this works?

@JeelRajodiya
Copy link
Member

JeelRajodiya commented Mar 10, 2024

@AdityaSingh-02, are you using npm ?

yup

yes, that is why the yarn.lock file is being modified.
You'll have use yarn instead of npm as suggested by @aialok in this comment

okay got it, so should I do everything again or this works?

can you run yarn install command and let me know if the yarn.lock file changes or not?
if the file changes commit and push those changes, that way the yarn.lock file will be back to it's original state.

@AdityaSingh-02
Copy link
Contributor Author

Heyy @aialok @JeelRajodiya Thank you for your guidance, I followed your steps and pushed changes using yarn, and this time yarn.lock file didn't change

@JeelRajodiya
Copy link
Member

JeelRajodiya commented Mar 11, 2024

Hey @AdityaSingh-02, You have resolved the problem.
but I want to bring this section of the issue #483 to your attention.
image

Let's just wait for the maintainer's review, before you proceeded any further

@benjagm
Copy link
Collaborator

benjagm commented Mar 11, 2024

It is not the solution I proposed but I like it. Thanks!

@benjagm benjagm merged commit 74711cd into json-schema-org:main Mar 11, 2024
3 checks passed
Akshaybagai52 pushed a commit to Akshaybagai52/website that referenced this pull request Mar 13, 2024
Akshaybagai52 pushed a commit to Akshaybagai52/website that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Improve behaviour of Draft 2020-12 for mobile devices
5 participants