-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: draft behaviour and hydration error #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pls. remove the changes from yarn.lock and package.lock.json file since it is increasing the pr size.
Also it will be good for users, if instead of applying overflow-auto , the 1x2 grid is converted into 2x1 grid as suggested in the issue : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you deleted the entire yarn.lock file.
As @DhairyaMajmudar mentioned, please leave the yarn.lock file as it is ( do not make any changes nor delete it )
Yup, I deleted it completely(by mistake), I should have stashed changes before pushing, I will take care of it from next time, Till then what should I do? will it affect the code? since I have not added any new dependencies, the file has minor changes it should not affect code base(I might be wrong here) |
@AdityaSingh-02, a better approach would be to clone the project from the beginning using Yarn and leave this as it is. Check out the |
Heyy @JeelRajodiya I have reverted the changes, could you look at it again? |
@AdityaSingh-02, are you using npm ? |
yup |
yes, that is why the yarn.lock file is being modified. You'll have use yarn instead of npm as suggested by @aialok in this comment |
okay got it, so should I do everything again or this works? |
can you run |
Heyy @aialok @JeelRajodiya Thank you for your guidance, I followed your steps and pushed changes using yarn, and this time yarn.lock file didn't change |
Hey @AdityaSingh-02, You have resolved the problem. Let's just wait for the maintainer's review, before you proceeded any further |
It is not the solution I proposed but I like it. Thanks! |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
Before
Screen.Recording.2024-03-10.at.9.41.58.AM.mov
After
Screen.Recording.2024-03-10.at.9.54.39.AM.mov
If relevant, did you update the documentation?
Summary
1- Here I have fixed the behavior of the table before it was taking full width and there was not any overflow or width property.
2- I have also made changes in the release-notes.md, which was causing a hydration error and I made a change at line number 466. it was taking more than required width.
Does this PR introduce a breaking change?